Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

Conversation

@erezrokah
Copy link
Contributor

Fixes #243

We should merge #244 first, then publish a release, then merge this PR.

@erezrokah erezrokah requested a review from ehmicky December 16, 2020 18:31
@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Dec 16, 2020
1. Merge the release PR
2. Switch to the default branch `git checkout master`
3. Pull latest changes `git pull`
4. Publish the package `npm publish`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we might want to have a common CONTRIBUTING.md to avoid duplication between repositories, what do you think?
At least for part of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I forgot to do it in node-template. See netlify/node-template#13

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also thinking of just putting some URL to point a common file, so we don't need to update all CONTRIBUTING.md when we make changes, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could create a dedicate repo just for code of conduct and contributing guide or put it under https://github.com/netlify/eslint-config-node, WDYT?

Copy link
Contributor

@ehmicky ehmicky Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either works! 👍
Maybe eslint-config-node would make some sense for the contributing guide since linting and code formatting are a big part of the flow. But a separate repository would work as well.

@erezrokah erezrokah force-pushed the chore/add_release_please branch from 1b9158e to b9f2008 Compare December 16, 2020 18:57
@erezrokah erezrokah merged commit 199e901 into master Dec 20, 2020
@erezrokah erezrokah deleted the chore/add_release_please branch December 20, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: add release flow via PRs

3 participants