This repository was archived by the owner on Oct 10, 2022. It is now read-only.
fix: fix package.json and files in package.json
#329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Feb 18, 2021
package.json
Outdated
| "!*~" | ||
| "src/**/*.js", | ||
| "!src/**/*.test.js", | ||
| "dist/main.js" |
Contributor
There was a problem hiding this comment.
Do we want to publish dist/main.js.map?
JGAntunes
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 7 changed the way globbing patterns are interpreted in
filesinpackage.json. This is undocumented, so I'm not sure whether this is a bug or not. This results in all*~files (Vim temporary files) to be published to npm, which can double the package size.This PR fixes this. I ran
npm pack --drybefore and after to ensure no files were being omitted.Before.:
199.1 KB(packed),928.8 KB(unpacked)After:
48.4 KB(packed),281.1 KB(unpacked)