Skip to content
This repository was archived by the owner on Oct 10, 2022. It is now read-only.

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 11, 2021

Part of https://github.com/netlify/bitballoon/issues/9616

This makes the js-client retry on any ECONNRESET error response. This happens when the TCP socket is closed, which happens from time to time in production due to transient reasons.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label May 11, 2021
@ehmicky ehmicky requested a review from erezrokah May 11, 2021 16:17
@ehmicky ehmicky self-assigned this May 11, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehmicky you should merge this as fix:

@ehmicky ehmicky changed the title chore: add ECONNRESET to error.code fix: add ECONNRESET to error.code May 11, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 11, 2021
@ehmicky ehmicky merged commit d573ae8 into main May 11, 2021
@ehmicky ehmicky deleted the fix/add-econnreset branch May 11, 2021 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants