Change localhost port to avoid macOS collision #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
approved these changes
Nov 17, 2022
Contributor
aitchiss
left a comment
aitchiss
left a comment
There was a problem hiding this comment.
OMG I've had this on my "to investigate" list for too long - I've always had this error locally and my googling did not yield such excellent results 😅 With this change it's all working now!
Could not approve this PR more strongly 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the plugin locally, I've started getting 403 responses:
Turns out macOS uses port 5000 for Airplay. We should use a different one!
Googling tells me we can reclaim 5000 by disabling this system prefs option, but as I've never used this, I'm guessing "on" is the default choice.