Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Conversation

@ericapisani
Copy link
Contributor

@ericapisani ericapisani commented Jul 20, 2022

Fixes #29

Changes were required due to breaking changes in next@12.2

Related docs: https://nextjs.org/blog/next-12-2#middleware-stable and https://nextjs.org/docs/messages/middleware-upgrade-guide

Changes were required due to breaking changes in next@12.2
@ericapisani ericapisani added the type: bug code to address defects in shipped code label Jul 20, 2022
@ericapisani ericapisani self-assigned this Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for ep-next-middleware-demo ready!

Name Link
🔨 Latest commit 3712d29
🔍 Latest deploy log https://app.netlify.com/sites/ep-next-middleware-demo/deploys/62d955f4d1f0e100091ce55f
😎 Deploy Preview https://deploy-preview-41--ep-next-middleware-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ericapisani ericapisani marked this pull request as ready for review July 21, 2022 13:40
@ericapisani ericapisani requested a review from a team July 21, 2022 13:40
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewrite is working in the middleware even though the country is undefined when the page loads. The undefined country is out of scope from this fix.

@ericapisani ericapisani merged commit 26dd104 into main Jul 21, 2022
@ericapisani ericapisani deleted the ep/update-middleware-file-structure branch July 21, 2022 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: bug code to address defects in shipped code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update for new middleware format

3 participants