Skip to content

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 30, 2020

This PR adds Gatsby plugin again, effectively reverting #13.

This should be merged only once the plugin is stable, including the issues listed here.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 30, 2020
@ehmicky ehmicky self-assigned this Mar 30, 2020
@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 1, 2020

It appears that there was nothing wrong with the Gatsby cache plugin, see this comment. So we can merge this PR and show it again after it's been code reviewed. 🎉

@jlengstorf @verythorough @nasivuela

Copy link
Contributor

@verythorough verythorough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ehmicky ehmicky merged commit 63bda66 into master Apr 1, 2020
@ehmicky ehmicky deleted the docs/add-gatsby branch April 1, 2020 15:40
@jlengstorf
Copy link
Contributor

It appears that there was nothing wrong with the Gatsby cache plugin

VINDICATED 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants