Skip to content

Conversation

@bentocodeing
Copy link
Contributor

Description:

This plugin allows you to transfer environment variables in the runtime of your application from those declared in your netlify.toml file and which are only executed at build time.

You can even override variables defined in the Netlify UI!


Thanks for contributing the Netlify plugins directory!

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan
Please add a link to a successful public deploy log using the stated version of the plugin. Include any other context reviewers might need for testing.

For test plan, see: https://app.netlify.com/sites/use-env-in-runtime-plugin-demo/deploys/6106f295e858e60008be2c41

This plugin allows you to transfer environment variables in the runtime of your application from those declared in your netlify.toml file and which are only executed at build time.

You can even override variables defined in the Netlify UI!
@netlify-bot
Copy link
Collaborator

netlify-bot commented Aug 1, 2021

@ehmicky ehmicky requested a review from eduardoboucas August 2, 2021 12:27
@eduardoboucas
Copy link
Member

Hi @ARKHN3B! Thanks for submitting your plugin.

As per our Plugin Author Guidelines, plugins must provide a zero-config default if they are to be installable via the UI. This includes not relying on required inputs, which your plugin seems to do.

Can you change it so that you're able to provide a zero-config default?

@ehmicky
Copy link
Contributor

ehmicky commented Aug 4, 2021

Thanks a lot for this plugin @ARKHN3B!

This is a great idea. One popular Build plugin netlify-plugin-contextual-env is quite similar. The only difference is that the prefix is always "context or branch" instead of being user-defined.

What are your thoughts on adding that feature to this existing plugin instead? For example, you could add a prefixes input and make it default to [context, branch].

@bentocodeing
Copy link
Contributor Author

bentocodeing commented Aug 9, 2021

Thanks a lot for this plugin @ARKHN3B!

This is a great idea. One popular Build plugin netlify-plugin-contextual-env is quite similar. The only difference is that the prefix is always "context or branch" instead of being user-defined.

What are your thoughts on adding that feature to this existing plugin instead? For example, you could add a prefixes input and make it default to [context, branch].

Thank you for the suggestion @ehmicky!

I think this changes the philosophy of this plugin a bit. But I'm 💯 up for collaborating on this project and adding this logic on it.

I will work on it and submit a PR soon 🙂

@ehmicky
Copy link
Contributor

ehmicky commented Aug 9, 2021

Thanks @ARKHN3B!

@bentocodeing
Copy link
Contributor Author

Hi @ARKHN3B! Thanks for submitting your plugin.

As per our Plugin Author Guidelines, plugins must provide a zero-config default if they are to be installable via the UI. This includes not relying on required inputs, which your plugin seems to do.

Can you change it so that you're able to provide a zero-config default?

Thank you for your response @eduardoboucas!

I've been working on it and I think my plugin fits Netlify's requirements now 🙂

@ehmicky ehmicky requested review from ehmicky and removed request for eduardoboucas August 13, 2021 11:10
@ehmicky ehmicky changed the title Update plugins.json feat: add netlify-plugin-use-env-in-runtime Aug 19, 2021
@ehmicky
Copy link
Contributor

ehmicky commented Aug 19, 2021

Thanks for your patience @ARKHN3B!
I have found a few minor issues, which I reported on your repository. Please let me know what you think!

@bentocodeing
Copy link
Contributor Author

Thanks for your patience @ARKHN3B!
I have found a few minor issues, which I reported on your repository. Please let me know what you think!

Thanks to you @ehmicky ! 💯

Good comments, thank you for the time you used to review my code. It's always good to have an external feedback. 🙂

I've had time to implement your feedback, it should be fine now.

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ARKHN3B! 🎉

@ehmicky ehmicky merged commit 5b9f1dd into netlify:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants