test: add integration tests for the Vite plugin #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
test/plugin-integration-test
branch
4 times, most recently
from
c615f28 to
58a119b
Compare
serhalp
commented
May 30, 2025
serhalp
commented
May 30, 2025
Comment on lines
64
to
175
| .withFile( | ||
| 'vite.config.js', | ||
| `import { defineConfig } from 'vite'; | ||
| import netlify from '@netlify/vite-plugin'; | ||
| export default defineConfig({ | ||
| plugins: [ | ||
| netlify() | ||
| ] | ||
| });`, | ||
| ) |
Member
Author
There was a problem hiding this comment.
There was also the option of programmatically passing in the actual plugin to createServer, but I felt like this was an even more end-to-end integration test, behaving like a user.
mrstork
reviewed
May 30, 2025
mrstork
reviewed
May 30, 2025
mrstork
previously approved these changes
May 30, 2025
serhalp
changed the title
serhalp
force-pushed
the
test/plugin-integration-test
branch
from
63d6338 to
ee41ced
Compare
pieh
approved these changes
Jun 2, 2025
serhalp
commented
Jun 2, 2025
| root: directory, | ||
| }) | ||
|
|
||
| const response = await fetch(url) |
Member
Author
There was a problem hiding this comment.
Note: all these fetch calls are replaced with playwright page.goto() calls in a follow-up PR, so we can ensure the rendered pages actually fully work end-to-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.