fix: revamp dev and vite plugin logging #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hook into the vite logger when using the vite plugin - fix weird unicode issue - use terminal colour lib with a smaller footprint - remove an extraneous logger util - add a basic message to inform the user that the Netlify Vite plugin loaded - when using middleware mode, add a message informing the user that this is loaded and listing enables features - add test coverage for logs
serhalp
force-pushed
the
serhalp/frb-1839-review-and-polish-logging-behaviour
branch
from
383dd96 to
05bfa6e
Compare
serhalp
force-pushed
the
serhalp/frb-1839-review-and-polish-logging-behaviour
branch
from
65fab98 to
c77505d
Compare
mrstork
reviewed
Jun 3, 2025
| }, | ||
| "dependencies": { | ||
| "@netlify/dev": "4.1.0", | ||
| "@netlify/dev-utils": "^3.1.0", |
Contributor
There was a problem hiding this comment.
Nice! I did some of these fixes in #261 as well
mrstork
reviewed
Jun 3, 2025
| await Promise.allSettled(this.#cleanupJobs.map((task) => task())) | ||
| } | ||
|
|
||
| public getEnabledFeatures(): string[] { |
Contributor
There was a problem hiding this comment.
Would you be able to share a screenshot example of this output?
Member
Author
There was a problem hiding this comment.
🤔 it's all in the PR description already!
mrstork
reviewed
Jun 3, 2025
mrstork
previously approved these changes
Jun 3, 2025
mrstork
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@netlify/dev-utilsBefore
Unlinked site
Linked site
You can't even tell if the Netlify plugin is running 😢
After
Unlinked site
Linked site
middleware: false