fix!: add named exports for global-config utils #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keanu-a
changed the title
keanu-a
changed the title
5 tasks
Member
|
@keanu-a since this changes what's exported from the package, this is technically a breaking change, so let's rename the PR to start with |
serhalp
reviewed
Jul 17, 2025
packages/dev-utils/src/main.ts
Outdated
| export { ensureNetlifyIgnore } from './lib/gitignore.js' | ||
| export { headers, toMultiValueHeaders } from './lib/headers.js' | ||
| export * as globalConfig from './lib/global-config.js' | ||
| export { default as getGlobalConfigStore, GlobalConfigStore, resetConfigCache } from './lib/global-config.js' |
Member
There was a problem hiding this comment.
sorry for churning, but now that I look at it... maybe we can just change the ./lib/global-config module to export getGlobalConfigStore as a named export instead of a default export? it's a little weird as is, and we're here making a breaking change anyway
Contributor
Author
There was a problem hiding this comment.
No its okay! I agree with changing the default export. Changed to named export
keanu-a
changed the title
serhalp
deleted the
keanualoua/ex-357-replace-export-of-globalconfig-in-netlifydev-utils-with
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from namespace export of
global-configutils to explicit named exports