Skip to content

fix(types): allow global.Netlify declaration merging #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

fix(types): allow global.Netlify declaration merging #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8224cd
docs: fix misleading comments
serhalp Oct 21, 2025
a44d0ff
fix(types): allow `global.Netlify` declaration merging
serhalp Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/edge-functions/prod/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import type { NetlifyGlobal } from '@netlify/types'

declare global {
// Using `var` so that the declaration is hoisted in such a way that we can
// reference it before it's initialized.

// Using `var` instead of `const` to allow TypeScript declaration merging.
// Multiple packages can declare the same global with `var`, but `const` cannot be redeclared.
var Netlify: NetlifyGlobal
}

Expand Down
4 changes: 3 additions & 1 deletion packages/functions/prod/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import type { NetlifyGlobal } from '@netlify/types'

declare global {
const Netlify: NetlifyGlobal
// Using `var` instead of `const` to allow TypeScript declaration merging.
// Multiple packages can declare the same global with `var`, but `const` cannot be redeclared.
var Netlify: NetlifyGlobal
}

export { builder } from './lib/builder.js'
Expand Down
5 changes: 2 additions & 3 deletions packages/runtime/src/lib/globals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import type { Context, NetlifyGlobal } from '@netlify/types'
import { GlobalScope } from './util.js'

declare global {
// Using `var` so that the declaration is hoisted in such a way that we can
// reference it before it's initialized.

// Using `var` instead of `const` to allow TypeScript declaration merging.
// Multiple packages can declare the same global with `var`, but `const` cannot be redeclared.
var Netlify: NetlifyGlobal
}

Expand Down