Refactor extractor fields #146
Conversation
ronensc
force-pushed
the
refactor-extractor-fields
branch
from
55049f8 to
e6babc9
Compare
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 57.78% 58.37% +0.58%
==========================================
Files 51 51
Lines 2916 2950 +34
==========================================
+ Hits 1685 1722 +37
+ Misses 1117 1116 -1
+ Partials 114 112 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ronensc
force-pushed
the
refactor-extractor-fields
branch
from
e6babc9 to
14db167
Compare
eranra
left a comment
eranra
left a comment
There was a problem hiding this comment.
Need to update the documentation (at least the README.md) to reflect the changes.
| // The test sends flows in 2 batches. Each batch is passed through the extractor and the encoder. | ||
| // The output of each stage is verified. | ||
| // The output of the 2nd batch depends on the 1st batch. | ||
| func Test_Extract_Encode(t *testing.T) { |
eranra
left a comment
eranra
left a comment
There was a problem hiding this comment.
Need to update the https://github.com/netobserv/flowlogs-pipeline/blob/main/docs/confGenerator.md do to explain when to use recent_op_value and when to use recent_count
I'll do that as part of #147 since it already edits the file |
3 participants
This PR:
recent_op_valueandrecent_countto the extractor output to be used in prometheus countersIt will follow up with PRs to add RawValuesOperation and a filter field to prom encoder config