Skip to content

Refactor extractor fields #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2022
Merged

Refactor extractor fields #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9ef90c0
Add recent_op_value and recent_count
ronensc Mar 14, 2022
ffde58d
Update Counter's source
ronensc Mar 14, 2022
0131f68
Add integration test between extractor and prom encoder
ronensc Mar 14, 2022
cad6c49
rename fields
ronensc Mar 14, 2022
2c8e3fb
Update a comment
ronensc Mar 14, 2022
14db167
Update network_definitions
ronensc Mar 14, 2022
17460da
Address Eran's comment: Panic in initValue() on unknown operation
ronensc Mar 20, 2022
6f53a6d
Address Eran's comment: add prefix "total" to count and value
ronensc Mar 20, 2022
07abc65
Address Eran's comment: change struct member to be unexported
ronensc Mar 20, 2022
9a07363
Address Eran's comment: rename and move common test func to test/utils
ronensc Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions contrib/kubernetes/flowlogs-pipeline.conf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,105 +165,105 @@ parameters:
metrics:
- name: bandwidth_per_network_service
type: counter
valuekey: bandwidth_network_service_value
valuekey: bandwidth_network_service_recent_op_value
labels:
- by
- aggregate
buckets: []
- name: bandwidth_per_source_destination_subnet
type: counter
valuekey: bandwidth_source_destination_subnet_value
valuekey: bandwidth_source_destination_subnet_recent_op_value
labels:
- by
- aggregate
buckets: []
- name: bandwidth_per_source_subnet
type: counter
valuekey: bandwidth_source_subnet_value
valuekey: bandwidth_source_subnet_recent_op_value
labels:
- by
- aggregate
buckets: []
- name: connections_per_destination_subnet
type: counter
valuekey: dest_connection_subnet_count_value
valuekey: dest_connection_subnet_recent_count
labels:
- by
- aggregate
buckets: []
- name: connections_per_source_subnet
type: counter
valuekey: src_connection_count_value
valuekey: src_connection_count_recent_count
labels:
- by
- aggregate
buckets: []
- name: connections_per_tcp_flags
type: counter
valuekey: TCPFlags_count_value
valuekey: TCPFlags_recent_count
labels:
- by
- aggregate
buckets: []
- name: connections_per_destination_as
type: counter
valuekey: dst_as_connection_count_value
valuekey: dst_as_connection_recent_count
labels:
- by
- aggregate
buckets: []
- name: connections_per_source_as
type: counter
valuekey: src_as_connection_count_value
valuekey: src_as_connection_recent_count
labels:
- by
- aggregate
buckets: []
- name: count_per_source_destination_subnet
type: counter
valuekey: count_source_destination_subnet_value
valuekey: count_source_destination_subnet_recent_count
labels:
- by
- aggregate
buckets: []
- name: egress_per_destination_subnet
type: counter
valuekey: bandwidth_destination_subnet_value
valuekey: bandwidth_destination_subnet_recent_op_value
labels:
- by
- aggregate
buckets: []
- name: egress_per_namespace
type: counter
valuekey: bandwidth_namespace_value
valuekey: bandwidth_namespace_recent_op_value
labels:
- by
- aggregate
buckets: []
- name: connections_per_destination_location
type: counter
valuekey: dest_connection_location_count_value
valuekey: dest_connection_location_recent_count
labels:
- by
- aggregate
buckets: []
- name: mice_count
type: counter
valuekey: mice_count_value
valuekey: mice_count_recent_count
labels:
- by
- aggregate
buckets: []
- name: elephant_count
type: counter
valuekey: elephant_count_value
valuekey: elephant_count_recent_count
labels:
- by
- aggregate
buckets: []
- name: service_count
type: counter
valuekey: dest_service_count_value
valuekey: dest_service_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/bandwidth_per_network_service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ encode:
metrics:
- name: bandwidth_per_network_service
type: counter
valuekey: bandwidth_network_service_value
valuekey: bandwidth_network_service_recent_op_value
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/bandwidth_per_src_dest_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ encode:
metrics:
- name: bandwidth_per_source_destination_subnet
type: counter
valuekey: bandwidth_source_destination_subnet_value
valuekey: bandwidth_source_destination_subnet_recent_op_value
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/bandwidth_per_src_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ encode:
metrics:
- name: bandwidth_per_source_subnet
type: counter
valuekey: bandwidth_source_subnet_value
valuekey: bandwidth_source_subnet_recent_op_value
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/connection_rate_per_dest_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ encode:
metrics:
- name: connections_per_destination_subnet
type: counter
valuekey: dest_connection_subnet_count_value
valuekey: dest_connection_subnet_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/connection_rate_per_src_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ encode:
metrics:
- name: connections_per_source_subnet
type: counter
valuekey: src_connection_count_value
valuekey: src_connection_count_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/connection_rate_per_tcp_flags.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ encode:
metrics:
- name: connections_per_tcp_flags
type: counter
valuekey: TCPFlags_count_value
valuekey: TCPFlags_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/connections_per_dst_as.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ encode:
metrics:
- name: connections_per_destination_as
type: counter
valuekey: dst_as_connection_count_value
valuekey: dst_as_connection_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/connections_per_src_as.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ encode:
metrics:
- name: connections_per_source_as
type: counter
valuekey: src_as_connection_count_value
valuekey: src_as_connection_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/count_per_src_dest_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ encode:
metrics:
- name: count_per_source_destination_subnet
type: counter
valuekey: count_source_destination_subnet_value
valuekey: count_source_destination_subnet_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/egress_bandwidth_per_dest_subnet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ encode:
metrics:
- name: egress_per_destination_subnet
type: counter
valuekey: bandwidth_destination_subnet_value
valuekey: bandwidth_destination_subnet_recent_op_value
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/egress_bandwidth_per_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ encode:
metrics:
- name: egress_per_namespace
type: counter
valuekey: bandwidth_namespace_value
valuekey: bandwidth_namespace_recent_op_value
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/geo-location_rate_per_dest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ encode:
metrics:
- name: connections_per_destination_location
type: counter
valuekey: dest_connection_location_count_value
valuekey: dest_connection_location_recent_count
labels:
- by
- aggregate
Expand Down
4 changes: 2 additions & 2 deletions network_definitions/mice_elephants.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ encode:
metrics:
- name: mice_count
type: counter
valuekey: mice_count_value
valuekey: mice_count_recent_count
labels:
- by
- aggregate
- name: elephant_count
type: counter
valuekey: elephant_count_value
valuekey: elephant_count_recent_count
labels:
- by
- aggregate
Expand Down
2 changes: 1 addition & 1 deletion network_definitions/network_services_count.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ encode:
metrics:
- name: service_count
type: counter
valuekey: dest_service_count_value
valuekey: dest_service_recent_count
labels:
- by
- aggregate
Expand Down
Loading