Skip to content

Align build steps - distinguish clean vs dev builds#109

Merged
jotak merged 3 commits intonetobserv:mainfrom
jotak:align-builds
Nov 13, 2024
Merged

Align build steps - distinguish clean vs dev builds#109
jotak merged 3 commits intonetobserv:mainfrom
jotak:align-builds

Conversation

@jotak
Copy link
Member

@jotak jotak commented Oct 29, 2024

  • Reducing the Dockerfile dependencies allows faster dev builds
  • Optimize docker caching wrt oc-commands dependencies
  • Align also with other repos wrt build date / version (it was not correctly implemented, with variable names mismatch)
  • Remove duplicated "make build" definitions

- Reducing the Dockerfile dependencies allows faster dev builds
- Optimize docker caching wrt oc-commands dependencies
- Align also with other repos wrt build date / version (it was not correctly implemented, with variable names mismatch)
- Remove duplicated "make build" definitions
@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.00%. Comparing base (0398f3b) to head (49eb8b2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   25.08%   26.00%   +0.92%     
==========================================
  Files           8        8              
  Lines        1148     1315     +167     
==========================================
+ Hits          288      342      +54     
- Misses        839      952     +113     
  Partials       21       21              
Flag Coverage Δ
unittests 26.00% <0.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
main.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-cli:76ad8dd

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=76ad8dd make commands

or download the updated commands.

Dockerfile Outdated
@@ -15,16 +14,17 @@ COPY main.go main.go
COPY go.mod go.mod
COPY go.sum go.sum
COPY commands/ commands/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move that one after the collector build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: 49eb8b2

@jotak jotak merged commit 6de3cd0 into netobserv:main Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants