Align build steps - distinguish clean vs dev builds#109
Align build steps - distinguish clean vs dev builds#109jotak merged 3 commits intonetobserv:mainfrom
Conversation
jotak
commented
Oct 29, 2024
- Reducing the Dockerfile dependencies allows faster dev builds
- Optimize docker caching wrt oc-commands dependencies
- Align also with other repos wrt build date / version (it was not correctly implemented, with variable names mismatch)
- Remove duplicated "make build" definitions
- Reducing the Dockerfile dependencies allows faster dev builds - Optimize docker caching wrt oc-commands dependencies - Align also with other repos wrt build date / version (it was not correctly implemented, with variable names mismatch) - Remove duplicated "make build" definitions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 25.08% 26.00% +0.92%
==========================================
Files 8 8
Lines 1148 1315 +167
==========================================
+ Hits 288 342 +54
- Misses 839 952 +113
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=76ad8dd make commands |
Dockerfile
Outdated
| @@ -15,16 +14,17 @@ COPY main.go main.go | |||
| COPY go.mod go.mod | |||
| COPY go.sum go.sum | |||
| COPY commands/ commands/ | |||
There was a problem hiding this comment.
Move that one after the collector build