NETOBSERV-2005: Allow populaiting only single filter rules for cli usecase#128
Conversation
|
@msherif1234: This pull request references NETOBSERV-2005 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 22.66% 22.66%
=======================================
Files 10 10
Lines 1337 1337
=======================================
Hits 303 303
Misses 1015 1015
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. |
jpinsonneau
left a comment
There was a problem hiding this comment.
Code looks good, thanks @msherif1234 !
d96ac0d to
a05ae75
Compare
|
New changes are detected. LGTM label has been removed. |
2119fea to
af28e89
Compare
|
/retest |
|
@msherif1234: This pull request references NETOBSERV-2005 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d352060 to
f0234af
Compare
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
f0234af to
338eef1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@msherif1234: This pull request references NETOBSERV-2005 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
ebpf agent will support multi flow filter rules however we will limit cli to only single rule
till we find a more efficient way to pass in more rules
Dependencies
netobserv/netobserv-ebpf-agent#473
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.