NETOBSERV-2358 exit on daemonset failure with logs#373
NETOBSERV-2358 exit on daemonset failure with logs#373openshift-merge-bot[bot] merged 4 commits intonetobserv:mainfrom
Conversation
scripts/functions.sh
Outdated
| } | ||
|
|
||
| function checkClusterVersion() { | ||
| version=$(${K8S_CLI_BIN} get clusterversion version -o jsonpath='{.status.history[*].version}') |
There was a problem hiding this comment.
what does history[*] do exactly? Pick first/any? Just wondering if that works if the history contains old cluster versions ...
There was a problem hiding this comment.
[*] is the equivalent of map here.
If multiple versions are listed there I will end with an array in $version 🤔
I should probably lock that using the Completed state as we do in the operator side.
There was a problem hiding this comment.
That will do the job: 651f944
If the version is not found, I will simply skip the check with a warning since the cluster is probably upgrading.
|
|
||
| echo "OpenShift version: $version" | ||
| if [[ "$command" = "packets" ]]; then | ||
| compare_versions "$version" 4.16.0 |
There was a problem hiding this comment.
do you know if compare_versions will work with funky versions like nightly / ci and others?
There was a problem hiding this comment.
Integration tests passed using OpenShift version: 4.20.0-0.nightly-2025-09-01-101753
You can find all the logs in the artifact folder: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/netobserv_network-observability-cli/373/pull-ci-netobserv-network-observability-cli-main-integration-tests/1962885449894596608/artifacts/integration-tests/netobserv-cli-tests/artifacts/
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 17.20% 17.20%
=======================================
Files 15 15
Lines 2133 2133
=======================================
Hits 367 367
Misses 1740 1740
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/ok-to-test |
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=2f285a0 make commands |
|
/label qe-approved |
|
/approve |
|
/retest |
looks like an infra issue where cluster didn't come up. I see it was passed previously. Let's see if re-test comes better. |
it passed on re-run, we're good to merge here. |
Awesome, thanks for the confirmation |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: memodi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
Description
The eBPF agent errors at startup will be displayed in CLI.
Example on OCP 4.15 with latest eBPF agent on packet capture (unsupported kernel):
Since the error from eBPF agent may be not very explicit, I have added a check per OCP version (when available):
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.