Skip to content

NETOBSERV-2435 backport#396

Merged
jotak merged 1 commit intonetobserv:release-1.10from
jpinsonneau:2435_backport
Oct 6, 2025
Merged

NETOBSERV-2435 backport#396
jotak merged 1 commit intonetobserv:release-1.10from
jpinsonneau:2435_backport

Conversation

@jpinsonneau
Copy link
Member

Backport of #395

@jpinsonneau jpinsonneau requested review from jotak and memodi October 2, 2025 13:13
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 28.75000% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.84%. Comparing base (e0e480b) to head (87b8b11).
⚠️ Report is 1 commits behind head on release-1.10.

Files with missing lines Patch % Lines
cmd/metric_capture.go 0.00% 21 Missing ⚠️
cmd/display.go 0.00% 13 Missing ⚠️
cmd/flow_capture.go 0.00% 8 Missing ⚠️
cmd/packet_capture.go 0.00% 7 Missing ⚠️
cmd/root.go 0.00% 5 Missing ⚠️
cmd/flow_display.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10     #396      +/-   ##
================================================
+ Coverage         13.67%   13.84%   +0.16%     
================================================
  Files                18       18              
  Lines              2684     2731      +47     
================================================
+ Hits                367      378      +11     
- Misses             2291     2329      +38     
+ Partials             26       24       -2     
Flag Coverage Δ
unittests 13.84% <28.75%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/metric_display.go 0.00% <ø> (ø)
cmd/flow_display.go 25.48% <88.46%> (+1.86%) ⬆️
cmd/root.go 22.60% <0.00%> (-0.61%) ⬇️
cmd/packet_capture.go 0.00% <0.00%> (ø)
cmd/flow_capture.go 6.48% <0.00%> (-0.39%) ⬇️
cmd/display.go 0.00% <0.00%> (ø)
cmd/metric_capture.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@memodi
Copy link
Member

memodi commented Oct 3, 2025

/label qe-approved

@jotak
Copy link
Member

jotak commented Oct 6, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2025
@jotak jotak merged commit 302082a into netobserv:release-1.10 Oct 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants