Skip to content

NETOBSERV-1627 Add commands to image for CI#76

Merged
jpinsonneau merged 2 commits intonetobserv:mainfrom
jpinsonneau:ci_commands
Aug 19, 2024
Merged

NETOBSERV-1627 Add commands to image for CI#76
jpinsonneau merged 2 commits intonetobserv:mainfrom
jpinsonneau:ci_commands

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented Aug 9, 2024

Description

Add oc-commands output to collector image to easy get it from CI.
This could also be usefull for users having the container image but not the script installed locally :)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@memodi
Copy link
Copy Markdown
Member

memodi commented Aug 9, 2024

/lgtm

@memodi
Copy link
Copy Markdown
Member

memodi commented Aug 9, 2024

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.08%. Comparing base (77624ac) to head (e12f691).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   26.08%   26.08%           
=======================================
  Files           8        8           
  Lines        1081     1081           
=======================================
  Hits          282      282           
  Misses        778      778           
  Partials       21       21           
Flag Coverage Δ
unittests 26.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jpinsonneau jpinsonneau changed the title Add commands to image for CI NETOBSERV-1627 Add commands to image for CI Aug 12, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Aug 13, 2024

New changes are detected. LGTM label has been removed.

@Amoghrd
Copy link
Copy Markdown
Member

Amoghrd commented Aug 19, 2024

@jpinsonneau Can we get this merged so that the related QE PR can be merged post that

@jpinsonneau
Copy link
Copy Markdown
Member Author

@jpinsonneau Can we get this merged so that the related QE PR can be merged post that

sure ! Let me fix and merge this

@jpinsonneau jpinsonneau merged commit 4cdeeea into netobserv:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants