Skip to content

NETOBSERV-1915 allow unbounded variables in functions#94

Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
jpinsonneau:unbounded_var
Oct 3, 2024
Merged

NETOBSERV-1915 allow unbounded variables in functions#94
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
jpinsonneau:unbounded_var

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented Oct 3, 2024

Description

Fix case where plugin complains about missing NETOBSERV_AGENT_IMAGE environment variable.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau changed the title allow unbounded variables in functions NETOBSERV-1915 allow unbounded variables in functions Oct 3, 2024
@jpinsonneau
Copy link
Copy Markdown
Member Author

Merging this upstream to give a try on a new release

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.08%. Comparing base (135a110) to head (334306a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   25.08%   25.08%           
=======================================
  Files           8        8           
  Lines        1148     1148           
=======================================
  Hits          288      288           
  Misses        839      839           
  Partials       21       21           
Flag Coverage Δ
unittests 25.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@openshift-merge-bot openshift-merge-bot bot merged commit 7968ad6 into netobserv:main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant