refactor(lobby): polish pass after PR #22#23
Merged
Conversation
GameKey.iconRes() returned the Crash drawable for Coinflip with a note that the branch only existed to keep the when exhaustive. That was a latent bug: RecentRoundRow walks every GameKey, so a Coinflip round would render with the wrong icon. Adds a proper coinflip drawable (two overlapping circles) and points the when branch at it. Also drops the leftover "notifications sheet deferred" comment at the LobbyHeader call site since the empty lambda already documents the intent.
The right meta label (RTP / Last / Up to) uses tnum digits while the left meta label (European, Classic, Multiplier, 5x5 Grid) uses only letters. Plain Top / Bottom row alignment renders the two with a visible vertical offset because the two glyph sets report different line metrics. alignByBaseline pins them to the typographic baseline so they read as a single label pair. Coinflip's HEADS . TAILS keeps the explicit Alignment.Bottom modifier because its row mixes the badge, the title+subtitle column and the meta label - baseline alignment would tie it to the title row.
netqo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GameKey.iconRes()previously returned the Crash drawable for Coinflip with a note that the branch only existed to keep thewhenexhaustive. That was a latent bug:RecentRoundRowwalks everyGameKey, so a Coinflip round would render the wrong icon. Adds a properic_game_coinflip.xmldrawable (two overlapping circles, heads / tails) and points thewhenbranch at it./* notifications sheet deferred */comment at theLobbyHeadercall site since the empty lambda already documents the intent.Modifier.alignByBaseline()on both Texts). The right label usestnumdigits and was rendering at a different vertical position than the plain-letter left label under default Top alignment; baseline alignment is the typographically correct fix.Test plan