bug: `make install-aws` fails — missing install_aws.sh script

[magicsunday]

Problem

make install-aws fails with:

./scripts/install_aws.sh
make: ./scripts/install_aws.sh: No such file or directory
make: *** [Makefile.d/user.mk:160: install-aws] Error 127

Root Cause

The target in Makefile.d/user.mk:160 calls ./scripts/install_aws.sh, but this script does not exist. The catalog entry catalog/aws.json defines install_method: "aws_installer", and the corresponding backend installer scripts/installers/aws_installer.sh exists and is functional.

The generic scripts/install_tool.sh already supports this tool:

$ ./scripts/install_tool.sh aws install

Fix

Option A (recommended): Change the Makefile target to use the generic installer:

install-aws: scripts-perms ## Install AWS CLI
	./scripts/install_tool.sh aws install

Option B: Create a thin scripts/install_aws.sh wrapper:

#!/usr/bin/env bash
set -euo pipefail
DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
ACTION="${1:-install}"
exec "$DIR/install_tool.sh" aws "$ACTION"

Option A is preferred as it reduces script proliferation and leverages the existing catalog system consistently.

Also affected

The dynamic targets make upgrade-aws and make uninstall-aws also call ./scripts/install_aws.sh update / uninstall and would fail for the same reason. If Option A is chosen, these pattern targets (upgrade-%, uninstall-%) in user.mk lines 91/184 should also be updated to use install_tool.sh.

Files to modify

• Makefile.d/user.mk — update install-aws: target (and optionally the upgrade-%/uninstall-% patterns)