feat: add fork workflow pattern and archived actions docs#36
Conversation
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by providing essential guidelines for contributing to upstream projects via a fork. It clarifies best practices for managing remotes and crafting pull requests, and introduces a crucial section on identifying and handling archived GitHub Actions to prevent reliance on unmaintained CI workflows. The additions aim to streamline the contribution process and improve the robustness of CI setups. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation on fork-based contribution workflows and checking for archived GitHub Actions. The information is clear and useful. I've suggested one improvement to align the remote naming convention with the widely-accepted standard (origin for the fork, upstream for the original repo) to enhance clarity and prevent confusion for contributors.
Note: Security Review has been skipped due to the limited scope of the PR.
…ginal) Address unresolved PR #36 review feedback: adopt the widely accepted convention where origin points to the fork and upstream to the original. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
- SKILL.md: trim to 495 words (under 500 limit) — tightened description, removed redundant "See ..." pointers already covered by the references table. - SKILL.md / checkpoints.yaml GH-36: bump reviewThreads(first:50) to first:100 (GraphQL max) and document pageInfo.hasNextPage pagination so PRs with >100 threads aren't silently mis-reported as "all resolved". - checkpoints.yaml GH-34: tighten the 40-hex-SHA negative lookahead so refs like @<40hex>-tag are correctly flagged as non-SHA-pinned; the previous \b boundary let any 40-hex prefix pass. - checkpoints.yaml GH-35: drop the trailing "|| exit 0" and the "2>/dev/null" wrapper on the Python harden-runner check so real failures (and the "Jobs missing harden-runner..." message) actually surface; missing python3/PyYAML cases are still handled explicitly upstream. Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Summary
Context
Learnings from contributing to
TYPO3-Documentation/codesnippetvia thenetresearch/codesnippetfork.Test plan