docs: prefer GitHub native attestations over slsa-verifier#38
Conversation
…Y.md template Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's security documentation to streamline release verification processes. It introduces a preference for GitHub's native attestation verification method, making it the recommended approach, while clearly marking the slsa-verifier method as legacy. Additionally, it enhances security configuration guidance by adding a crucial note about the immutability of GitHub releases, advising against deleting and recreating releases to fix provenance issues. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to recommend GitHub's native attestations for release verification over slsa-verifier. The changes in SECURITY.md.template are clear and introduce the new recommended method while marking the old one as legacy. I've added one suggestion to security-config.md to clarify the reasoning behind treating releases as immutable, as the current explanation about tags being 'permanently locked' is not strictly accurate.
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Project skill’s security documentation to recommend GitHub CLI’s native attestation verification workflow ahead of the legacy slsa-verifier flow, and adds an additional note under the SLSA pinning exception guidance.
Changes:
- Add a “Using GitHub Attestations (Recommended)” verification section to
SECURITY.md.template. - Rename the existing SLSA verifier instructions to “Using slsa-verifier (Legacy)”.
- Add an “Immutable releases” warning under the SLSA Generator Pinning Exception in
security-config.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/github-project/references/security-config.md | Adds a cautionary note under the SLSA generator pinning exception section. |
| skills/github-project/assets/SECURITY.md.template | Adds GitHub attestation verification instructions and relabels slsa-verifier instructions as legacy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Summary
SECURITY.md.templatebefore the existing slsa-verifier instructions —gh attestation verifyis simpler and natively supportedsecurity-config.mdunder the SLSA Generator Pinning Exception sectionTest plan