docs(references): secrets-inherit ban, config_data pitfall, archived-repo handling#80
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation on handling Dependabot/Renovate PRs in archived repositories, warns about inline configuration overrides in reusable workflows, and advises against using secrets: inherit for security reasons. Feedback was provided to improve the robustness of the jq filter in the gh command using optional chaining, and to fix a bash syntax error and YAML formatting issue in the heredoc example.
CybotTM
force-pushed
the
feat/migrate-claude-rules
branch
from
c2f6be7 to
5cc9c41
Compare
…ved-repo handling Migrated from a personal global rules file so the whole team shares them: - reusable-workflow-security: never use `secrets: inherit` (forwards every secret transitively; limits blast radius to named secrets) - reusable-workflow-pitfalls: #5 inline `config_data` replaces the repo's own linter config entirely instead of merging - auto-merge-guide: handle Dependabot/Renovate PRs on archived repos (unarchive -> close -> re-archive; never auto-merge archived) Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM
force-pushed
the
feat/migrate-claude-rules
branch
from
5cc9c41 to
d809b85
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three GitHub-ops rules migrated from a personal
~/.claude/CLAUDE.mdinto the skill (team memory).reusable-workflow-security.mdsecrets: inherit— explicit per-secret passing, blast-radius rationalereusable-workflow-pitfalls.mdconfig_dataoverrides the repo's own config (fallback pattern)auto-merge-guide.mdmarkdownlint-cli2: 0 errors. Docs only. Skipped a 4th candidate ("annotations must be resolved") — already covered by the existing CI Annotations section.