ci(release): grant SLSA provenance permissions#17
Merged
Conversation
Required by netresearch/skill-repo-skill/.github/workflows/release.yml, which generates SLSA build-provenance attestations for release archives via actions/attest-build-provenance. The reusable workflow's attest job needs id-token: write (OIDC for sigstore) and attestations: write (GitHub native attestation API) on the calling job. Also drops pull-requests: write — the reusable workflow doesn't touch the pulls API; it was over-privileging.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the release workflow permissions so the upstream reusable release workflow can mint SLSA build provenance attestations during releases.
Changes:
- Adds
id-token: writeto enable OIDC-based signing (sigstore) for the attest job - Adds
attestations: writeto allow publishing provenance via GitHub’s attestation API - Adjusts existing permissions for the release job
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grants the two permissions the upstream reusable release workflow at
netresearch/skill-repo-skillneeds in order to publish a SLSA build-provenance attestation for every release archive.Why
This is part of an org-wide rollout flipping SLSA build-provenance attestations to always on in the reusable release workflow. The first cut shipped the feature behind an opt-in input (
with: attest: true); on review, opt-in was the wrong call — every release artefact in the org should have provenance, and the cost of "always on" is a tiny one-time permission grant per consumer (this PR).Sequencing
This PR lands first. After every consumer of
netresearch/skill-repo-skill/.github/workflows/release.yml@mainhas merged the equivalent change, the upstream will drop the opt-in input and theif:gate so the attest job always runs. No window of broken releases either way: callers that already grant the permissions are forward-compatible.Test plan
gh attestation verify <archive> --owner netresearch