Skip to content

chore(release): drop deprecated with: block and workflow_dispatch.bump#18

Merged
CybotTM merged 1 commit intomainfrom
chore/drop-deprecated-release-inputs
Apr 30, 2026
Merged

chore(release): drop deprecated with: block and workflow_dispatch.bump#18
CybotTM merged 1 commit intomainfrom
chore/drop-deprecated-release-inputs

Conversation

@CybotTM
Copy link
Copy Markdown
Member

@CybotTM CybotTM commented Apr 30, 2026

Summary

Drops the now-deprecated bits from this caller's release workflow:

  • The workflow_dispatch: trigger and its bump input. The upstream reusable workflow's bump input has been documented DEPRECATED — ignored since the auto-bump job was removed; clicking "Run workflow" in the GitHub UI was a no-op.
  • The with: block (bump: only, or bump: + attest: for matrix-skill). attest was deprecated in netresearch/skill-repo-skill#79 when SLSA build provenance flipped from opt-in to always-on; bump has been deprecated for longer.
  • Stale comments on the id-token/attestations permission lines that referenced the old "when attest: true" phrasing.
 on:
   push:
     tags:
       - 'v*'
-  workflow_dispatch:
-    inputs:
-      bump:
-        description: 'Version bump type'
-        required: true
-        type: choice
-        options:
-          - patch
-          - minor
-          - major

 jobs:
   release:
     uses: netresearch/skill-repo-skill/.github/workflows/release.yml@main
-    with:
-      bump: ${{ inputs.bump }}
     permissions:
       contents: write          # release upload
-      id-token: write          # OIDC for sigstore (required when attest: true)
-      attestations: write      # GitHub native attestation API (required when attest: true)
+      id-token: write          # OIDC for sigstore (required by the attest job)
+      attestations: write      # GitHub native attestation API (required by the attest job)

Behaviour change

None. Releases still trigger on signed tag-push and produce SLSA-attested archives. The workflow_dispatch UI button did nothing functional already; this just removes the dead button.

Test plan

  • CI green on this PR
  • Next release of this repo continues to publish to the GitHub releases page with SLSA attestation, verifiable via gh attestation verify <archive>.zip --owner netresearch

Both inputs that this caller used to pass to the upstream reusable
release workflow are now deprecated/ignored:

  - `bump` was deprecated when the auto-bump job was removed from
    skill-repo-skill (releases now happen via signed tag-push only).
  - `attest` (matrix-skill only) was deprecated when SLSA build
    provenance flipped from opt-in to always-on in
    netresearch/skill-repo-skill#79.

Removing them keeps release.yml honest. Also drops the
workflow_dispatch trigger entirely — clicking "Run workflow" did
nothing useful since the upstream only acts on tag-push. Comments on
the id-token/attestations grants are normalized away from
"required when attest: true" to "required by the attest job".

Net effect: zero behaviour change. Releases continue to ship via
signed tag-push and produce SLSA-attested archives.
Copilot AI review requested due to automatic review settings April 30, 2026 09:04
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@CybotTM CybotTM merged commit 4c51837 into main Apr 30, 2026
7 checks passed
@CybotTM CybotTM deleted the chore/drop-deprecated-release-inputs branch April 30, 2026 09:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes deprecated/ignored inputs and trigger wiring from the release workflow caller, aligning it with the upstream reusable workflow’s current interface.

Changes:

  • Removed the workflow_dispatch trigger and deprecated bump input.
  • Dropped the deprecated with: bump: ... input passed into the reusable release workflow.
  • Updated permissions comments to reflect the current “attest job” requirement wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants