Conversation
Both inputs that this caller used to pass to the upstream reusable
release workflow are now deprecated/ignored:
- `bump` was deprecated when the auto-bump job was removed from
skill-repo-skill (releases now happen via signed tag-push only).
- `attest` (matrix-skill only) was deprecated when SLSA build
provenance flipped from opt-in to always-on in
netresearch/skill-repo-skill#79.
Removing them keeps release.yml honest. Also drops the
workflow_dispatch trigger entirely — clicking "Run workflow" did
nothing useful since the upstream only acts on tag-push. Comments on
the id-token/attestations grants are normalized away from
"required when attest: true" to "required by the attest job".
Net effect: zero behaviour change. Releases continue to ship via
signed tag-push and produce SLSA-attested archives.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes deprecated/ignored inputs and trigger wiring from the release workflow caller, aligning it with the upstream reusable workflow’s current interface.
Changes:
- Removed the
workflow_dispatchtrigger and deprecatedbumpinput. - Dropped the deprecated
with: bump: ...input passed into the reusable release workflow. - Updated permissions comments to reflect the current “attest job” requirement wording.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the now-deprecated bits from this caller's release workflow:
workflow_dispatch:trigger and itsbumpinput. The upstream reusable workflow'sbumpinput has been documentedDEPRECATED — ignoredsince the auto-bump job was removed; clicking "Run workflow" in the GitHub UI was a no-op.with:block (bump:only, orbump:+attest:for matrix-skill).attestwas deprecated in netresearch/skill-repo-skill#79 when SLSA build provenance flipped from opt-in to always-on;bumphas been deprecated for longer.id-token/attestationspermission lines that referenced the old "when attest: true" phrasing.on: push: tags: - 'v*' - workflow_dispatch: - inputs: - bump: - description: 'Version bump type' - required: true - type: choice - options: - - patch - - minor - - major jobs: release: uses: netresearch/skill-repo-skill/.github/workflows/release.yml@main - with: - bump: ${{ inputs.bump }} permissions: contents: write # release upload - id-token: write # OIDC for sigstore (required when attest: true) - attestations: write # GitHub native attestation API (required when attest: true) + id-token: write # OIDC for sigstore (required by the attest job) + attestations: write # GitHub native attestation API (required by the attest job)Behaviour change
None. Releases still trigger on signed tag-push and produce SLSA-attested archives. The
workflow_dispatchUI button did nothing functional already; this just removes the dead button.Test plan
gh attestation verify <archive>.zip --owner netresearch