fix: harden GitHub Actions against supply chain attacks#23
Conversation
This hardens the repository against supply chain attacks like the aquasecurity/trivy-action compromise (2026-03-19). Changes: - Pin all GitHub Actions to immutable commit SHAs - Add/update Dependabot configuration for github-actions ecosystem Ref: netresearch/ofelia#535 Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the security posture of the repository's CI/CD workflows by implementing best practices against supply chain attacks. By enforcing SHA-pinning for all GitHub Actions, it mitigates risks associated with malicious tag or branch force-pushes. Additionally, the introduction of Dependabot for GitHub Actions ensures that all workflow dependencies are automatically kept up-to-date, further reducing potential security vulnerabilities and maintenance overhead. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a Dependabot configuration to manage updates for GitHub Actions. While this is a good practice for keeping actions up-to-date, the repository already contains a renovate.json file. The default Renovate configuration also handles GitHub Actions updates, which means you might get duplicate pull requests from both Dependabot and Renovate. It is recommended to consolidate on a single tool for this task to avoid confusion.
Furthermore, the pull request description states that GitHub Actions have been pinned to commit SHAs, but these changes are not reflected in the provided diff. This might be an oversight and could cause the CI to fail if SHA pinning is enforced at the organization level as mentioned.
Summary
Context
On 2026-03-19,
aquasecurity/trivy-actionwas compromised via a tag force-push attack that exfiltrated secrets from CI runners. SHA-pinning prevents this class of attack entirely.The netresearch org now enforces
sha_pinning_required=true— workflows using tag/branch references will fail.Ref: netresearch/ofelia#535
Test plan