feat: add TYPO3-specific PSR and factory patterns reference#21
Merged
Conversation
Add reference: typo3-psr-patterns.md covering: - PSR-3 LoggerAwareInterface with NullLogger default - PSR-14 event dispatch with try/catch guard - Factory pattern with Imagick/GD capability fallback - Services.yaml factory wiring - ProcessorInterface for middleware decoupling - PHPStan baseline management practices Add checkpoints PM-26 through PM-28 for TYPO3-specific PSR compliance. Update SKILL.md with TYPO3-specific patterns section. Patterns established during t3x-nr-image-optimize session.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces TYPO3-specific PSR patterns and modernization guidelines, adding a new reference document and validation checkpoints for PSR-3 logging, PSR-14 event dispatching, and factory patterns. The feedback suggests clarifying the role of external classes in the factory pattern examples to improve documentation completeness.
Fix ImagickDriver/GdDriver to use proper Intervention\Image\Drivers FQCNs Add missing use statements to PSR-14 and ProcessorInterface examples Clarify ProcessorInterface is HTTP-specific, note domain alternative Add PHPStan explanation for getLogger() null coalescing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typo3-psr-patterns.mdwith TYPO3-specific implementations of:Context
During t3x-nr-image-optimize development, these PHP patterns were established but the php-modernization skill only covered generic PSR patterns, not TYPO3-specific implementations.
Test plan