PresenterComponentReflection::combineArgs() should retype variables i… #100
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice catch! |
Member
There was a problem hiding this comment.
Can you change it to simpler $reflection = new ReflectionMethod('MyPresenter', 'myMethod'); ?
Contributor
|
👍 It's an annoying bug in v2.3.6. |
Contributor
Author
There was a problem hiding this comment.
How about I use the foreach instead?
foreach ($method->getParameters() as $i => $param) {
Contributor
There was a problem hiding this comment.
If the items in $method->getParameters() are indexed by numbers starting from zero then yes, it would be better.
Contributor
Author
There was a problem hiding this comment.
Yeah, it returns regular array indexed from zero; I've changed it.
Contributor
|
@peteruhnak Squash all the commits into one please. |
…n the $res array. [Fixes #99] Use foreach's automatic indexing instead of manual one.
dg
added a commit
that referenced
this pull request
Oct 13, 2015
PresenterComponentReflection::combineArgs() should retype variables i…
Contributor
|
@dg Please when we would expect fixed release v2.3.7 (for orientation)? |
Member
|
Soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n the $res array. [Fixes #99]