Session: nette-browser cookie may be sent with secure flag#102
Closed
PavelJurasek wants to merge 1 commit intonette:masterfrom
Closed
Session: nette-browser cookie may be sent with secure flag#102PavelJurasek wants to merge 1 commit intonette:masterfrom
PavelJurasek wants to merge 1 commit intonette:masterfrom
Conversation
JanTvrdik
reviewed
Sep 15, 2016
src/Http/Session.php
Outdated
| $this->response->setCookie( | ||
| 'nette-browser', $_SESSION['__NF']['B'], | ||
| Response::BROWSER, $cookie['path'], $cookie['domain'] | ||
| Response::BROWSER, $cookie['path'], $cookie['domain'], $cookie['secure'] |
Contributor
There was a problem hiding this comment.
- Why not pass httponly option as well?
- This has been removed in 0aed1a2, not sure why
Contributor
Author
There was a problem hiding this comment.
You are right, I'll add httponly too.
PavelJurasek
force-pushed
the
feature-secure-nette-browser
branch
from
7c5bda3 to
223aebc
Compare
Member
|
What's the reason? |
Contributor
Author
|
Mixed content is being sent when site in on HTTPS. |
Member
|
It is error message? In which browser? |
Contributor
Author
|
There is no error nor warning in browsers. At least not when HSTS is used. PS: this is not urgent and necessary PR |
Member
|
Closed by #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.