Skip to content

Few improvements and bugfixes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 9, 2014
Merged

Few improvements and bugfixes #19

merged 12 commits into from
Nov 9, 2014

Conversation

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Oct 31, 2014

No description provided.

@fprochazka
Copy link
Contributor

fprochazka commented Oct 31, 2014

Apart from Request: raw body is now passed as callback via constructor, I like it. I understand why you've done it like that, but I'm not sure that's the best. But it probably is better than the current state.

👍

@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented Oct 31, 2014

The only other solution I could think of was passing handle to readable stream but that would be a lot more complicated to implement properly. But it would be cleaner. Not sure about performance though.

@JanTvrdik JanTvrdik mentioned this pull request Nov 1, 2014
Closed
@JanTvrdik JanTvrdik force-pushed the improvements branch 4 times, most recently from c1700e9 to 94afa1d Compare November 6, 2014 16:31
@dg
Copy link
Member

dg commented Nov 8, 2014

Great work! Could you remove this commit JanTvrdik@b29988f, it can be discussed separatelly in #21.

@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented Nov 9, 2014

@dg updated as requested

dg added a commit that referenced this pull request Nov 9, 2014
@dg
Merge pull request #19 from JanTvrdik/improvements
1552e9c 
Few improvements and bugfixes
@dg dg merged commit 1552e9c into nette:master Nov 9, 2014
@JanTvrdik JanTvrdik deleted the improvements branch November 9, 2014 23:20
castamir
castamir reviewed Nov 10, 2014
View reviewed changes
src/Http/Helpers.php
Copy link

@castamir castamir Nov 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it better to use $time->format('D, d M Y H:i:s e')?

@JanTvrdik JanTvrdik mentioned this pull request Aug 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JanTvrdik @fprochazka @dg @castamir