Fix Http\Request::getFile() inconsistency

[JanTvrdik]

Http\Request::getFile() is inconsistent with getQuery and getPost

• it uses Nette\Utils\Arrays::get; getQuery and getPost do not
• it does not support $default but always returns NULL (that kind of make sense) for undefined keys.

[JanTvrdik]

Solved by JanTvrdik@4c45beb

[dg]

The reason is that getFile returns (as leafs) objects. For query and post data you can use:

$post['x'] = 123;
isset( $post['x']['y']['z'] ); // return FALSE

but not for files:

$files['x'] = new stdClass;
isset( $files['x']['y']['z'] ); // FATAL ERROR

[JanTvrdik]

One note: Nette itself never uses methods getQuery(), getPost() or getFile() to get a specific key. Method getCookie with specific key is used in sessions.

What I love about it is consistency.
What I hate about it is performance. Getting a specific has now much bigger overhead. However it would have very little impact on the framework itself.

[dg]

I agree with need for consistency, but I think that better way is to deprecate current (unused) getFile behavior than increase complexity, that nobody needs.

Deprecate getFile is BC break, this solution is BC break for maintainers of own IRequest implementations.

[JanTvrdik]

ok, will do

[JanTvrdik]

Done – is it OK now?

[dg]

👍