Skip to content

getFrom() can be null (in @mail() function) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

getFrom() can be null (in @mail() function) #63

wants to merge 1 commit into from

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented May 10, 2019

  • bug fix
  • BC break? yes (fixing BC)

In past version of Message method getFrom() can return null value and SMTP server used default configuration.

If header from is null, now throw E_USER_WARNING.

Now Message return:

Snímek obrazovky 2019-05-10 v 9 55 16

dg pushed a commit that referenced this pull request Jun 3, 2019
@janbarasek @dg
fixed typehints (#61, #63)
f60b1fb
@dg
Copy link
Member

dg commented Jun 3, 2019

merged (without E_WARNING, it makes inconsistency)

@dg dg closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbarasek @dg