Skip to content

Conversation

@evaniacheng
Copy link
Contributor

This task takes in the top k websites of Alexa's top-ranked websites, outputting their traceroute path, ping times, DNS resolution times, and time to first byte. It is implemented using Linux-based tools like traceroute, ping, dig, and curl. Results are saved into a file in JSON format. Optional parameters allow users to specify input filepath, output_path, and the top k amount of websites to measure.

Copy link
Contributor

@maybe-hello-world maybe-hello-world left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I left a bunch of comments about using Failure class in case of Failure, it applies to other cases further in the file that I haven't left comments too, but basically - see the similar situations where I mentioned it :D

"curl",
"-o", "/dev/null",
"-s",
"-w", "%{time_starttransfer}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the next timers:

  • time_appconnect
  • time_connect
  • time_namelookup
  • time_posttransfer
  • time_pretransfer
  • time_queue
  • time_redirect
  • time_total

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented all of them except time_posttranfer and time_queue because curl doesn't have these two timers

@maybe-hello-world
Copy link
Contributor

LGTM

@maybe-hello-world maybe-hello-world merged commit 860dbf2 into netunicorn:main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants