- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10
 
Added Alexa Task Implementation #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I left a bunch of comments about using Failure class in case of Failure, it applies to other cases further in the file that I haven't left comments too, but basically - see the similar situations where I mentioned it :D
        
          
                tasks/measurements/alexa/alexa.py
              
                Outdated
          
        
      | "curl", | ||
| "-o", "/dev/null", | ||
| "-s", | ||
| "-w", "%{time_starttransfer}", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add the next timers:
- time_appconnect
 - time_connect
 - time_namelookup
 - time_posttransfer
 - time_pretransfer
 - time_queue
 - time_redirect
 - time_total
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented all of them except time_posttranfer and time_queue because curl doesn't have these two timers
| 
           LGTM  | 
    
This task takes in the top k websites of Alexa's top-ranked websites, outputting their traceroute path, ping times, DNS resolution times, and time to first byte. It is implemented using Linux-based tools like traceroute, ping, dig, and curl. Results are saved into a file in JSON format. Optional parameters allow users to specify input filepath, output_path, and the top k amount of websites to measure.