feat(probe): add per-hop latency/loss annotations to probe analysis hop chain#12
Merged
Conversation
…op chain - Extend HopDetail with latency, loss, and is_rate_limited fields - Aggregate per-hop metrics across all MTR traces in analyzeMtrForProbe - Update ProbeAnalysisView.vue to display color-coded latency/loss badges - Highlight rate-limited hops with dashed border and ICMP indicator - Update TypeScript HopDetail interface Resolves NET-15 Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the probe analysis hop chain to display per-hop latency and loss metrics, and visually distinguishes ICMP rate-limited hops.
Changes
Backend (
controller/internal/probe/analysis.go):latency,loss, andis_rate_limitedfields toHopDetailanalyzeMtrForProbenow aggregates per-hop metrics across all MTR tracesHopDetailbuildHopDetailsForMtrPayloadpopulates the new fieldsFrontend (
panel/src/components/analysis/ProbeAnalysisView.vue):Types (
panel/src/components/analysis/types.ts):HopDetailinterface to match backend changesChecklist
Resolves NET-15