fix: agent health scores#7
Merged
Merged
Conversation
…s, set offline agents to 0 health Co-authored-by: multica-agent <github@multica.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OverallHealth = 0(critical grade) instead of being penalized only -20 pointsChanges
controller/internal/probe/analysis.go:ComputeProbeAnalysis(): Changed PING, MTR, and TrafficSim metrics to only query source agent dataComputeWorkspaceAnalysis(): Offline agents get 0 health score instead of small penaltyWhy
Agents/targets that are completely offline should not pollute route analytics calculations. An offline agent's own health should be 0 (critical) since being offline is the worst state.