Fix several issues with Codeview debug information#178
Merged
hpax merged 1 commit intonetwide-assembler:masterfrom Dec 10, 2025
Merged
Fix several issues with Codeview debug information#178hpax merged 1 commit intonetwide-assembler:masterfrom
hpax merged 1 commit intonetwide-assembler:masterfrom
Conversation
Member
|
Pulled. |
|
This change expand on the #216, where previously it files without defined sections would fail. Now every file without code (.text) section is failing. Effectively making it not possible to assembly for example .rdata only file. |
kasper93
added a commit
to kasper93/nasm
that referenced
this pull request
Mar 30, 2026
Simply skip the tables that require code section and source information. Fixes: netwide-assembler#216 Fixes: netwide-assembler#178 (comment) Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following issues with Codeview debug information:
.pdatasection..text$…are used.%includefile defines only data what results in file reference with zero entries in line number table.Solution for issue 2. is partial: only for case of one such section per file.