-
-
Notifications
You must be signed in to change notification settings - Fork 23
[BUG] nmrs race condition #175
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workinglow-priorityDevelopment can continue without itDevelopment can continue without itnmrsChanges to nmrsChanges to nmrs
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinglow-priorityDevelopment can continue without itDevelopment can continue without itnmrsChanges to nmrsChanges to nmrs
https://github.com/cachebag/nmrs/blob/85ab4f594edde94c878d9910a53704e6dd5edecf/nmrs/src/core/state_wait.rs#L55-L62
We subscribe to signals AFTER creating the proxy, but there's still a window between subscription and checking current state where a state change could be missed.
If the state changes between subscribing and checking, we might miss it.
So I guess technically this is actually handled correctly (subscribe first, then check), but we should add a re-check after the loop to catch any state changes that occurred during the gap.