Skip to content

[BUG] nmrs race condition #175

@cachebag

Description

@cachebag

https://github.com/cachebag/nmrs/blob/85ab4f594edde94c878d9910a53704e6dd5edecf/nmrs/src/core/state_wait.rs#L55-L62

We subscribe to signals AFTER creating the proxy, but there's still a window between subscription and checking current state where a state change could be missed.

If the state changes between subscribing and checking, we might miss it.

So I guess technically this is actually handled correctly (subscribe first, then check), but we should add a re-check after the loop to catch any state changes that occurred during the gap.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglow-priorityDevelopment can continue without itnmrsChanges to nmrs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions