feat(nmrs): OpenVpn config expansion#309
Merged
cachebag merged 7 commits intonetworkmanager-rs:dev-openvpnfrom Mar 31, 2026
Merged
feat(nmrs): OpenVpn config expansion#309cachebag merged 7 commits intonetworkmanager-rs:dev-openvpnfrom
OpenVpn config expansion#309cachebag merged 7 commits intonetworkmanager-rs:dev-openvpnfrom
Conversation
cachebag
requested changes
Mar 26, 2026
Dandiggas
force-pushed
the
feat/add-openvpn-config
branch
from
aba40c4 to
8c4dfd1
Compare
cachebag
force-pushed
the
feat/add-openvpn-config
branch
from
05bc9d0 to
4345a74
Compare
cachebag
changed the title
OpenVpn config expansion
cachebag
approved these changes
Mar 31, 2026
Collaborator
cachebag
left a comment
cachebag
left a comment
There was a problem hiding this comment.
@Dandiggas Took the liberty to clean the PR up for you. You had it all right just needed some refinements based on my feedback. I was blocked by this on #314 so I figured I'd wrap this up myself.
Let me know if you have any questions or concerns. Thanks for this contribution!
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retroactive edit by @cachebag:
Closes #290