fix: toggle kernel rfkill for bluetooth in set_bluetooth_radio_enabled#418
Merged
Conversation
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rfkill block/unblock bluetooth) before toggling BlueZ adapterPoweredproperties inset_bluetooth_radio_enabledcosmic-settings-airplane-mode-subscription)processfeature to workspace tokio dependencyContext
When
set_airplane_modewas used in cosmic-applet-network (PR pop-os/cosmic-applets#1392), the airplane toggle would visually bounce back. Root cause: the applet's subscription determines airplane mode by checkingrfkill list bluetoothfor a soft block, but nmrs only toggled BlueZ D-BusPowered— which doesn't update kernel rfkill state. This meant the subscription would immediately read BT as "not blocked" and flip the toggle back.Related to issue seen in pop-os/cosmic-applets#1392 (comment)