Skip to content

Feat/#884 add metadata to Status#889

Merged
stevehu merged 6 commits intomasterfrom
feat/#884-status
Jan 4, 2021
Merged

Feat/#884 add metadata to Status#889
stevehu merged 6 commits intomasterfrom
feat/#884-status

Conversation

@BalloonWen
Copy link
Copy Markdown
Contributor

@BalloonWen BalloonWen commented Dec 31, 2020

added metadata to status

@BalloonWen
issue #884
55b5d5d 
- added showMessage, showMetadata, showDescription into status.yml
- now when calling Status toString(), the message, metadata, description part can be turn on and off selectively
- added powermock for status module
@BalloonWen
issue #884
fa32ec1 
- removed configs from status.yml since it will throw exception when merging from app-status.yml
- set default value in code with backward-compatible value
- added setStatusExchange with metadata method overload
@BalloonWen BalloonWen added dont-merge PR: Not ready to be merged 2.0.x Merge to 2.0.x Branch labels Dec 31, 2020
@BalloonWen
issue #884
25a3397 
- don't show metadata if metadata is null
- added tests
@BalloonWen
issue #884
816276c 
- removed duplicate version for mockito
@BalloonWen
issue #884
aad35e7 
- fixed NPE issue for put metadata
@BalloonWen BalloonWen removed the dont-merge PR: Not ready to be merged label Jan 4, 2021
stevehu
stevehu reviewed Jan 4, 2021
View reviewed changes
Comment thread status/src/main/java/com/networknt/status/Status.java Outdated
Comment thread handler/src/main/java/com/networknt/handler/LightHttpHandler.java
@BalloonWen
issue #884
5d96e8b 
- make metadata append json object instead of String
@stevehu stevehu merged commit 8548d09 into master Jan 4, 2021
@stevehu stevehu deleted the feat/#884-status branch January 4, 2021 16:36
@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Jan 4, 2021

@BalloonWen Could you please update the document for the status with the latest changes? Thanks.

@BalloonWen
Copy link
Copy Markdown
Contributor Author

BalloonWen commented Jan 4, 2021

@BalloonWen Could you please update the document for the status with the latest changes? Thanks.

Please take a look and advise networknt/light-doc#234

@BalloonWen BalloonWen linked an issue Jan 7, 2021 that may be closed by this pull request
add metadata to Status to support customizing info #884
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehu stevehu stevehu left review comments

@jaswalkiranavtar jaswalkiranavtar Awaiting requested review from jaswalkiranavtar

Assignees

No one assigned

Labels

2.0.x Merge to 2.0.x Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add metadata to Status to support customizing info

2 participants

@BalloonWen @stevehu