eslint issues in props validation

[stevehu]

The CircleCI build failed due to eslint issues below..

'form' is missing in props validation          react/prop-types

fixed them by adding to type Props object or ignore the line in ComposedComponent.

[stevehu]

@naeemba could you please review if this is the proper approach? Thanks.

[naeemba]

@stevehu Actually I did not get that, do we have some eslint errors in Array.js ComposedComponent.js MultiSelect.js and Select.js? cause when I run yarn lint there is no error for me.
Also as I know, there is no key inside props for Select or MultiSelect and the key is in form prop.
I am not sure, but I think I did not fully check eslint errors, so if you can help me to build the project locally I can find the related errors and fix them before sending the PR.

[stevehu]

yarn lint is OK but npm run lint got extra checks and shown errors. I know it doesn't make sense but I guess it should no negative impact.

[naeemba]

Actually I ran npm run lint just now, and it seems there is no error there too. Not sure what is different here, can you check your eslint version? I updated it to 5.11.1 in this branch and maybe it caused the problem.

[stevehu]

if you are using yarn install, then there is no problem. It only occurs if you are using npm install :)

[stevehu]

you need to remove node_modules and package-lock.json first.

[naeemba]

Yeah, I found it now, I am rebuilding the project. Thanks

[naeemba]

Actually I saw the errors just now, let me fix them and create another PR for that. thanks

[naeemba]

I fixed eslint errors, can you check it again?
And also I wanted to ask do you know why my name isn't in the contributor list of this library? Actually I have few commits on this project but my name isn't on the contributor list page of the project.

[stevehu]

It works perfectly. Thanks. It shows in the issue you are a contributor but I cannot find your name in the Contributors section. We have another developer got a similar issue before in another repo and the root cause is that he has two GitHub accounts. I realized that the commits don't associate with your avatar int the PR(#152). Are you using IDE or command line for git? What kind of OS are you using? I am using the Linux command line and I have to set up the following.

$ git config --global user.name "Steve Hu"
$ git config --global user.email stevehu@gmail.com

[naeemba]

Aha, maybe that is the cause of problem. let me check that, I use IDE for committing and pushing to git, thank you so much for your help.
I'll check that to fix the issue.
Thanks,
Naeem,

[stevehu]

I have published a new release 0.6.8 moment ago. Thanks a lot for your help.