Add network service to MonitorScopeSelector (#178)#179
Merged
denis-tingaikin merged 1 commit intonetworkservicemesh:mainfrom Dec 5, 2024
Merged
Add network service to MonitorScopeSelector (#178)#179denis-tingaikin merged 1 commit intonetworkservicemesh:mainfrom
denis-tingaikin merged 1 commit intonetworkservicemesh:mainfrom
Conversation
denis-tingaikin
approved these changes
Dec 4, 2024
Member
denis-tingaikin
left a comment
denis-tingaikin
left a comment
There was a problem hiding this comment.
Looks good. When CI is fixed, we can merge it.
@NikitaSkrynnik Please have a look if you get a chance.
zolug
force-pushed
the
ns-monitor-scope
branch
from
5e378ca to
f1d1904
Compare
Allow MonitorScopeSelector to filter connections based on network service as well. Signed-off-by: Lugossy Zoltan <zoltan.lugossy@est.tech>
zolug
force-pushed
the
ns-monitor-scope
branch
from
f1d1904 to
e2e147b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #178
Allow MonitorScopeSelector to filter connections based on network service as well.