Skip to content

Logging improvements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

Logging improvements #18

merged 1 commit into from
Oct 13, 2020

Conversation

@glennmatthews
Copy link
Collaborator

@glennmatthews glennmatthews commented Oct 13, 2020

  • Don't create a default logger object, as this gets in the way of configuring structlog ourselves (as in the SOT Sync project) before instantiating DSync objects.
  • Add LOG_UNCHANGED_RECORDS flag, and output debug messages when syncing unchanged records iff this flag is set.

@glennmatthews glennmatthews requested a review from dgarros October 13, 2020 18:22
@glennmatthews glennmatthews merged commit cbe903f into master Oct 13, 2020
@glennmatthews glennmatthews deleted the gfm-logging-improvements branch October 13, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgarros dgarros dgarros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glennmatthews @dgarros