Fix issue #136 #137
Merged
Fix issue #136 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszulczewski
requested review from
jeffkala,
lvrfrc87 and
scetron
as code owners
pszulczewski
force-pushed
the
fix_136
branch
from
f2858ec to
3033ab1
Compare
pszulczewski
force-pushed
the
fix_136
branch
from
3033ab1 to
25d48d5
Compare
pszulczewski
commented
Sep 4, 2025
Comment on lines
+187
to
+191
| # Pop the root "index_element" key. | ||
| if final_extras.get("index_element"): | ||
| final_extras.update(final_extras.pop("index_element")) | ||
| if final_missing.get("index_element"): | ||
| final_missing.update(final_missing.pop("index_element")) |
There was a problem hiding this comment.
New version of DeepDiff adds root key which is changed in jdiff to index_element. Pop the value to keep current behavior.
gertzakis
approved these changes
Sep 4, 2025
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136