Skip to content

Fix issue #136 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Fix issue #136 #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/136.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix GitHub release failing in CI pipeline.
15 changes: 9 additions & 6 deletions jdiff/utils/diff_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,14 @@ def process_diff(_map, extra_map, missing_map, previous_key=None):
final_extras = extras.copy()
final_missing = missing.copy()
for key, value in extras.items():
if isinstance(value, dict):
if not value:
del final_extras[key]
if isinstance(value, dict) and not value:
del final_extras[key]
for key, value in missing.items():
if isinstance(value, dict):
if not value:
del final_missing[key]
if isinstance(value, dict) and not value:
del final_missing[key]
# Pop the root "index_element" key.
if final_extras.get("index_element"):
final_extras.update(final_extras.pop("index_element"))
if final_missing.get("index_element"):
final_missing.update(final_missing.pop("index_element"))
Comment on lines +187 to +191
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version of DeepDiff adds root key which is changed in jdiff to index_element. Pop the value to keep current behavior.

return final_extras, final_missing