Skip to content

WIP: Fix issu #91 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: Fix issu #91 #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65ca814
add unittest placeholder
lvrfrc87 Nov 21, 2022
a8ead8a
draft unittest
lvrfrc87 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions tests/mock/napalm_get_interfaces/post.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
".local.": {
"description": "",
"is_enabled": false,
"is_up": false,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..0": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..1": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..2": {
"description": "",
"is_enabled": false,
"is_up": false,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
}
}
38 changes: 38 additions & 0 deletions tests/mock/napalm_get_interfaces/pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
".local.": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..0": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..1": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
},
".local..2": {
"description": "",
"is_enabled": true,
"is_up": true,
"last_flapped": -1,
"mac_address": "Unspecified",
"mtu": 0,
"speed": -1
}
}
1 change: 1 addition & 0 deletions tests/test_get_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ def test_jmspath_return_none(data):
extract_data_from_json(data=data, path=my_jmspath)() # pylint: disable=E0110

assert "JMSPath returned 'None'. Please, verify your JMSPath regex." in error.value.__str__()

34 changes: 34 additions & 0 deletions tests/test_issues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
"""jdiff github issues unit tests."""
import pytest
import jdiff
from jdiff import extract_data_from_json, CheckType
from .utility import load_mocks, ASSERT_FAIL_MESSAGE

issue_91 = (
"napalm_get_interfaces",
"exact_match",
{},
"$*$.[is_up,is_enabled]",
(
{},
False,
),
)

check_tests = [
issue_91,
]


@pytest.mark.parametrize("folder_name, check_type_str, evaluate_args, path, expected_result", check_tests)
def test_checks(folder_name, check_type_str, evaluate_args, path, expected_result):
"""Validate multiple checks on the same data to catch corner cases."""
check = CheckType.create(check_type_str)
pre_data, post_data = load_mocks(folder_name)
pre_value = extract_data_from_json(pre_data, path)
post_value = extract_data_from_json(post_data, path)
actual_results = check.evaluate(pre_value, post_value, **evaluate_args)

assert actual_results == expected_result, ASSERT_FAIL_MESSAGE.format(
output=actual_results, expected_output=expected_result
)