Fixed PanOS empty config parsing #804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewesch
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
joewesch
commented
Feb 3, 2026
| for _file in glob.glob(f"{MOCK_DIR}/find_all_children/{_network_os}/*{TXT_FILE}"): | ||
| find_all_children_parameters.append([_file, _network_os]) | ||
| for _file in glob.glob(f"{MOCK_DIR}/find_children_w_parents/{_network_os}/*{TXT_FILE}"): | ||
| find_children_w_parents_parameters.append([_file, _network_os]) |
Collaborator
Author
There was a problem hiding this comment.
This is just changing network_os to _network_os as the loop variable so that we don't perpetuate copy/pasting the same pylint disable comment over and over...
itdependsnetworks
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #803
The
PaloAltoNetworksConfigParserwas written contradictory to the rest of the parsers in that it raised an error when the configuration was empty. This PR changes that behavior to bring it in line with the rest of the parsers. I also added a unit test to verify that all parsers allow empty configurations and return an empty list.NTC-4957