NAPPS-968 | Adds device.install_mode to base driver and ios driver#395
Merged
Conversation
Pkawa-ntc
approved these changes
May 28, 2026
Pkawa-ntc
left a comment
Pkawa-ntc
left a comment
There was a problem hiding this comment.
Some nits to consider, other than that LGTM. Thanks James!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes NAPPS-968
What's Changed:
device.install_modeproperty to base driver that will raiseNotImplemented.device.install_modeproperty to IOS driver that will returnTrueifdevice.boot_options.get("sys") == "packages.conf". Otherwise it will returnFalse.install_modeargument in the IOS driver.