Merged
Conversation
…if the build was configured for just some subset of drivers [networkupstools#2081] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…filenames Sometimes we get this: Makefile:1216: update target 'asciidoc-vars.conf' due to: asciidoc-vars.conf-spellchecked rm -f "asciidoc-vars.conf" || true ; \ echo " ASPELL Spell checking on ./"; \ ... touch "asciidoc-vars.conf" ASPELL Spell checking on ./ sed: read error on stdin: Is a directory Only seen for "asciidoc-vars.conf" so far: :; git checkout -f ; touch docs/asciidoc-vars.conf ; make spellcheck ; clear ; make dist -j 20 --trace V=1 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
bug
packaging
CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2081 (to always distribute all man page sources - even if the build was configured only for a few drivers)
Note: thinking about it, this might still falter in contrived use-cases... The dist tarball is supposed to include pre-built man pages (from the distributor's system), so the building systems have an option to not re-generate the pages or even to not have tools for that, and yet to produce packages convenient for end-users. A
configure --with-drivers=usbhid-upssort of build config would only pre-generate and dist-tarball that driver's man page. TLDR: "real" dist tarballs should be made on systems capable of (and configured to) building all driver types.TODO: In fact, no system is able to build all driver types nowadays - e.g. some are specific to MacOS or Linux. A recipe toggle is needed, perhaps to
configurea build for dist purposes and force building all man pages (and/or other doc formats) regardless of being able to build the drivers.Other than that, with this PR I've also caught an annoying problem that sometimes
docs/asciidoc-vars.confjust disappeared. This was tracked down to strange mis-behavior of (GNU?) make: if Imake spellcheckand then e.g.make dist, it tries to:and passes an empty
"$(SPELLCHECK_SRC_ONE)"into it, however the target"$@"is set toasciidoc-vars.conf(for a rule targeting explicitly$(SPELLCHECK_BUILDDIR)/$(SPELLCHECK_SRC_ONE)-spellchecked: ...!) As a result, it deletes the target file and then fails to process the empty input. Strange case (only for this file) got strange workarounds with this PR...Just to clarify: it should never have got to update the documentation source due to touch-file at all, it should be the other way around!